netdev - Re: [PATCH bpf-next v2 0/5] samples: bpf: continue effort to get rid of bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW5nJ+29yc58h5QX=pr1d3WwzZfBF+gMuvmUrOwHoEZ-cg@mail.gmail.com>
Date:   Thu, 28 Feb 2019 11:16:06 -0800
From:   Song Liu <liu.song.a23@...il.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Networking <netdev@...r.kernel.org>, bpf@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH bpf-next v2 0/5] samples: bpf: continue effort to get rid
 of bpf_load

On Wed, Feb 27, 2019 at 7:05 PM Jakub Kicinski
<jakub.kicinski@...ronome.com> wrote:
>
> Hi!
>
> This set is next part of a quest to get rid of the bpf_load
> ELF loader.  It fixes some minor issues with the samples and
> starts the conversion.
>
> First patch fixes ping invocations, ping localhost defaults
> to IPv6 on modern setups. Next load_sock_ops sample is removed
> and users are directed towards using bpftool directly.
>
> Patch 4 removes the use of bpf_load from samples which don't
> need the auto-attachment functionality at all.
>
> Patch 5 improves symbol counting in libbpf, it's not currently
> an issue but it will be when anyone adds a symbol with a long
> name. Let's make sure that person doesn't have to spend time
> scratching their head and wondering why .a and .so symbol
> counts don't match.
>
> v2: - specify prog_type where possible (Andrii).

For the series:

Acked-by: Song Liu <songliubraving@...com>

Thanks for doing this work!
Song

>
> Jakub Kicinski (5):
>   samples: bpf: force IPv4 in ping
>   samples: bpf: remove load_sock_ops in favour of bpftool
>   tools: libbpf: add a correctly named define for map iteration
>   samples: bpf: use libbpf where easy
>   tools: libbpf: make sure readelf shows full names in build checks
>
>  samples/bpf/.gitignore                        |  1 -
>  samples/bpf/Makefile                          |  8 +-
>  samples/bpf/fds_example.c                     | 10 +-
>  samples/bpf/load_sock_ops.c                   | 97 -------------------
>  samples/bpf/sock_example.c                    |  2 +-
>  samples/bpf/sockex1_user.c                    | 25 ++---
>  samples/bpf/sockex2_user.c                    | 23 +++--
>  samples/bpf/sockex3_user.c                    |  2 +-
>  samples/bpf/tcp_basertt_kern.c                |  2 +-
>  samples/bpf/tcp_bpf.readme                    | 14 +--
>  samples/bpf/tcp_bufs_kern.c                   |  2 +-
>  samples/bpf/tcp_clamp_kern.c                  |  2 +-
>  samples/bpf/tcp_cong_kern.c                   |  2 +-
>  samples/bpf/tcp_iw_kern.c                     |  2 +-
>  samples/bpf/tcp_rwnd_kern.c                   |  2 +-
>  samples/bpf/tcp_synrto_kern.c                 |  2 +-
>  samples/bpf/tcp_tos_reflect_kern.c            |  2 +-
>  samples/bpf/tracex2_user.c                    |  2 +-
>  tools/bpf/bpftool/prog.c                      |  4 +-
>  tools/lib/bpf/Makefile                        |  4 +-
>  tools/lib/bpf/libbpf.c                        |  8 +-
>  tools/lib/bpf/libbpf.h                        |  3 +-
>  tools/perf/util/bpf-loader.c                  |  4 +-
>  .../testing/selftests/bpf/test_libbpf_open.c  |  2 +-
>  24 files changed, 69 insertions(+), 156 deletions(-)
>  delete mode 100644 samples/bpf/load_sock_ops.c
>
> --
> 2.19.2
>