netdev - Re: [PATCH bpf-next 2/5] libbpf: fix formatting for btf_ext__get_raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Feb 2019 11:20:01 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     Andrii Nakryiko <andriin@...com>, Kernel Team <kernel-team@...com>,
        Alexei Starovoitov <ast@...com>,
        Networking <netdev@...r.kernel.org>, bpf@...r.kernel.org,
        Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH bpf-next 2/5] libbpf: fix formatting for btf_ext__get_raw_data

On Thu, Feb 28, 2019 at 10:53 AM Arnaldo Carvalho de Melo
<arnaldo.melo@...il.com> wrote:
>
> Em Wed, Feb 27, 2019 at 02:46:38PM -0800, Andrii Nakryiko escreveu:
> > Fix invalid formatting of pointer arg.
> >
> > Fixes: ae4ab4b4117d ("btf: expose API to work with raw btf_ext data")
>
> Also I think Fixes here is not applicable :-)

Yeah, I was probably too pedantic, I'll remove it from v2 :)

>
> - Arnaldo
>
> > Signed-off-by: Andrii Nakryiko <andriin@...com>
> > ---
> >  tools/lib/bpf/btf.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/lib/bpf/btf.h b/tools/lib/bpf/btf.h
> > index 94bbc249b0f1..b60bb7cf5fff 100644
> > --- a/tools/lib/bpf/btf.h
> > +++ b/tools/lib/bpf/btf.h
> > @@ -76,7 +76,7 @@ LIBBPF_API int btf__get_map_kv_tids(const struct btf *btf, const char *map_name,
> >
> >  LIBBPF_API struct btf_ext *btf_ext__new(__u8 *data, __u32 size);
> >  LIBBPF_API void btf_ext__free(struct btf_ext *btf_ext);
> > -LIBBPF_API const void *btf_ext__get_raw_data(const struct btf_ext* btf_ext,
> > +LIBBPF_API const void *btf_ext__get_raw_data(const struct btf_ext *btf_ext,
> >                                            __u32 *size);
> >  LIBBPF_API int btf_ext__reloc_func_info(const struct btf *btf,
> >                                       const struct btf_ext *btf_ext,
> > --
> > 2.17.1
>
> --
>
> - Arnaldo