lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 1 Mar 2019 06:14:08 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
Cc:     kbuild-all@...org, David Miller <davem@...emloft.net>,
        netdev@...r.kernel.org, Jesper Dangaard Brouer <brouer@...hat.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>
Subject: Re: [PATCH net-next v2 3/3] xdp: Add devmap_idx map type for looking
 up devices by ifindex

Hi Toke,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/xdp-Use-a-default-map-for-xdp_redirect-helper/20190301-021039
config: x86_64-randconfig-l2-02281415 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/bpf-cgroup.h:5:0,
                    from include/linux/cgroup-defs.h:22,
                    from include/linux/cgroup.h:28,
                    from include/net/netprio_cgroup.h:17,
                    from include/linux/netdevice.h:46,
                    from drivers//tty/synclinkmp.c:55:
   include/linux/bpf.h: In function 'dev_map_inc_redirect_count':
   include/linux/bpf.h:731:1: warning: no return statement in function returning non-void [-Wreturn-type]
    }
    ^
   include/linux/bpf.h: At top level:
>> include/linux/bpf.h:738:13: warning: 'struct bpf_dtab_netdev' declared inside parameter list
         struct bpf_dtab_netdev *dst)
                ^
>> include/linux/bpf.h:738:13: warning: its scope is only this definition or declaration, which is probably not what you want

vim +738 include/linux/bpf.h

   728	
   729	static inline int dev_map_inc_redirect_count(void)
   730	{
 > 731	}
   732	
   733	static inline void dev_map_dec_redirect_count(void)
   734	{
   735	}
   736	
   737	static inline void __dev_map_insert_ctx(struct bpf_map *map,
 > 738						struct bpf_dtab_netdev *dst)
   739	{
   740	}
   741	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (29448 bytes)

Powered by blists - more mailing lists