lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 27 Feb 2019 16:21:44 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
        bpf@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [PATCH bpf-next 4/5] samples: bpf: use libbpf where easy

On Wed, 27 Feb 2019 16:05:45 -0800, Andrii Nakryiko wrote:
> >         if (object) {
> > -               assert(!load_bpf_file((char *)object));
> > -               return prog_fd[0];
> > +               assert(!bpf_prog_load(object, 0, &obj, &prog_fd));  
> 
> Here and in few more places below: is it possible to specify correct
> bpf_prog_type instead of 0?

Some of them yes, some of them no.  There are objects with multiple
program types IIRC.  This program type argument is only used for
checking if kernel versions are needed, and they are provided in
samples so it doesn't matter.

I'll try to add where possible.

Powered by blists - more mailing lists