netdev - Re: [PATCH net] ipv4: Pass original device to ip_rcv_finish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190227.214456.944810072109486180.davem@davemloft.net>
Date:   Wed, 27 Feb 2019 21:44:56 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, dsahern@...il.com, ecree@...arflare.com
Subject: Re: [PATCH net] ipv4: Pass original device to ip_rcv_finish_core

From: David Ahern <dsahern@...nel.org>
Date: Mon, 25 Feb 2019 13:55:48 -0800

> From: David Ahern <dsahern@...il.com>
> 
> ip_route_input_rcu expects the original ingress device (e.g., for
> proper multicast handling). The skb->dev can be changed by l3mdev_ip_rcv,
> so dev needs to be saved prior to calling it. This was the behavior prior
> to the listify changes.
> 
> Fixes: 5fa12739a53d0 ("net: ipv4: listify ip_rcv_finish")
> Cc: Edward Cree <ecree@...arflare.com>
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied and queued up for -stable, thanks Dave.