netdev - Re: [PATCH v3 4/6] ethtool: support per-queue sub command --show-coalesce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190301142634.GJ29992@unicorn.suse.cz>
Date:   Fri, 1 Mar 2019 15:26:34 +0100
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     linville@...driver.com,
        Nicholas Nunley <nicholas.d.nunley@...el.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH v3 4/6] ethtool: support per-queue sub command
 --show-coalesce

On Fri, Mar 01, 2019 at 12:15:30AM -0800, Jeff Kirsher wrote:
> From: Nicholas Nunley <nicholas.d.nunley@...el.com>
> 
> Get all masked queues' coalesce settings from kernel and dump them one by
> one.
> 
> Example:
> 
>  $ sudo ./ethtool --per-queue eth5 queue_mask 0x11 --show-coalesce
>  Queue: 0
>  Adaptive RX: off  TX: off
>  stats-block-usecs: 0
>  sample-interval: 0
>  pkt-rate-low: 0
>  pkt-rate-high: 0
> 
>  rx-usecs: 222
>  rx-frames: 0
>  rx-usecs-irq: 0
>  rx-frames-irq: 256
> 
>  tx-usecs: 222
>  tx-frames: 0
>  tx-usecs-irq: 0
>  tx-frames-irq: 256
> 
>  rx-usecs-low: 0
>  rx-frame-low: 0
>  tx-usecs-low: 0
>  tx-frame-low: 0
> 
>  rx-usecs-high: 0
>  rx-frame-high: 0
>  tx-usecs-high: 0
>  tx-frame-high: 0
> 
>  Queue: 4
>  Adaptive RX: off  TX: off
>  stats-block-usecs: 0
>  sample-interval: 0
>  pkt-rate-low: 0
>  pkt-rate-high: 0
> 
>  rx-usecs: 222
>  rx-frames: 0
>  rx-usecs-irq: 0
>  rx-frames-irq: 256
> 
>  tx-usecs: 222
>  tx-frames: 0
>  tx-usecs-irq: 0
>  tx-frames-irq: 256
> 
>  rx-usecs-low: 0
>  rx-frame-low: 0
>  tx-usecs-low: 0
>  tx-frame-low: 0
> 
>  rx-usecs-high: 0
>  rx-frame-high: 0
>  tx-usecs-high: 0
>  tx-frame-high: 0
> 
> Based on patch by Kan Liang <kan.liang@...el.com>
> 
> Signed-off-by: Nicholas Nunley <nicholas.d.nunley@...el.com>

Reviewed-by: Michal Kubecek <mkubecek@...e.cz>

> ---
>  ethtool.8.in |  2 +-
>  ethtool.c    | 68 +++++++++++++++++++++++++++++++++++++++++++++++++---
>  2 files changed, 66 insertions(+), 4 deletions(-)
> 
> diff --git a/ethtool.8.in b/ethtool.8.in
> index 10f24db..b4e240e 100644
> --- a/ethtool.8.in
> +++ b/ethtool.8.in
...
> @@ -5248,7 +5273,8 @@ static const struct option {
>  	{ "--show-fec", 1, do_gfec, "Show FEC settings"},
>  	{ "--set-fec", 1, do_sfec, "Set FEC settings",
>  	  "		[ encoding auto|off|rs|baser [...]]\n"},
> -	{ "-Q|--per-queue", 1, do_perqueue, "Apply per-queue command",
> +	{ "-Q|--per-queue", 1, do_perqueue, "Apply per-queue command."
> +	  "The supported sub commands include --show-coalesce",

Nitpick: missing space: "...per-queue command.The supported..."

Michal Kubecek