netdev - Re: [PATCH v3 6/6] ethtool: fix up dump_coalesce output to match actual option names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190301143801.GL29992@unicorn.suse.cz>
Date:   Fri, 1 Mar 2019 15:38:01 +0100
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     linville@...driver.com,
        Nicholas Nunley <nicholas.d.nunley@...el.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH v3 6/6] ethtool: fix up dump_coalesce output to match
 actual option names

On Fri, Mar 01, 2019 at 12:15:32AM -0800, Jeff Kirsher wrote:
> From: Nicholas Nunley <nicholas.d.nunley@...el.com>
> 
> When the coalesce settings are printed with --show-coalesce a few of the
> option names lack the pluralization that is present in the man page and
> usage info, but are otherwise identical.
> 
> This inconsistency could lead to some confusion if a user attempts to set
> the coalesce settings by matching the output they see from --show-coalesce,
> so fix this.
> 
> Signed-off-by: Nicholas Nunley <nicholas.d.nunley@...el.com>

Reviewed-by: Michal Kubecek <mkubecek@...e.cz>