netdev - Re: [PATCH] net: ipv6: check net in ip6_call_ra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190228.180824.2041984657827980829.davem@davemloft.net>
Date:   Thu, 28 Feb 2019 18:08:24 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     fruggeri@...sta.com
Cc:     dsahern@...il.com, yoshfuji@...ux-ipv6.org, kuznet@....inr.ac.ru,
        maxim@...sta.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: ipv6: check net in ip6_call_ra_chain

From: Francesco Ruggeri <fruggeri@...sta.com>
Date: Thu, 28 Feb 2019 16:09:17 -0800

> On Thu, Feb 28, 2019 at 3:31 PM David Ahern <dsahern@...il.com> wrote:
>>
>> On 2/28/19 2:02 PM, David Miller wrote:
>> > From: fruggeri@...sta.com (Francesco Ruggeri)
>> > Date: Thu, 28 Feb 2019 11:01:46 -0800
>> >
>> >> ip6_call_ra_chain is called when IPv6 packet with Router Alert option
>> >> is forwarded.
>> >> It needs to check if the net of the socket is the same as the net of the
>> >> input device, otherwise the packet gets delivered to every IPv6 socket
>> >> listening for Router Alerts, no matter which network namespace it is in.
>> >>
>> >> Suggested-by: Maxim Martynov <maxim@...sta.com>
>> >> Signed-off-by: Maxim Martynov <maxim@...sta.com>
>> >> Signed-off-by: Francesco Ruggeri <fruggeri@...sta.com>
>> >
>> > Right now someone using such a tool does get all RAs in the system.
>> >
>> > Your change not only breaks them, but also gives them no method by
>> > which to keep obtaining the same behavior.
>> >
>> > I don't know what to do or suggest in this situation, but right now
>> > I'm putting this patch on hold.
>> >
>>
>> need an equivalent to NETLINK_LISTEN_ALL_NSID
> 
> If that would be acceptable, we can look into it.

It is.