netdev - Re: [patch net-next RFC 3/8] net: devlink: introduce devlink_compat_switch_id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190301164051.GM2314@nanopsycho>
Date:   Fri, 1 Mar 2019 17:40:51 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, mlxsw@...lanox.com,
        idosch@...lanox.com, dirk.vandermerwe@...ronome.com,
        f.fainelli@...il.com, andrew@...n.ch, vivien.didelot@...il.com
Subject: Re: [patch net-next RFC 3/8] net: devlink: introduce
 devlink_compat_switch_id_get() helper

Fri, Mar 01, 2019 at 05:45:15PM CET, jakub.kicinski@...ronome.com wrote:
>On Fri,  1 Mar 2019 17:05:37 +0100, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@...lanox.com>
>> 
>> Introduce devlink_compat_switch_id_get() helper which fills up switch_id
>> according to passed netdev pointer. Call it directly from
>> dev_get_port_parent_id() as a fallback when ndo_get_port_parent_id
>> is not defined for given netdev.
>> 
>> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
>
>Here my locking concerns are even stronger :S  Do you want to introduce
>some extra ordering rules regarding lifetime of devlink ports and their
>netdevs?

Working on it.