netdev - Re: [PATCH net-next] net: dsa: Do not configure VLAN ID 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab4f9ea2-f108-1538-3a98-dd03d3657a16@gmail.com>
Date:   Fri, 1 Mar 2019 09:54:07 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Michal Vokáč <michal.vokac@...ft.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: Do not configure VLAN ID 0

On 3/1/19 9:52 AM, Florian Fainelli wrote:

[snip]

>> Tested-by: Michal Vokáč <michal.vokac@...ft.com>
>>
>> I am not sure what was the original problem as I could not find the
>> thread where Heiner reported the issue but with the latest version
>> next-20190228 I get this error with QCA8334 switch:
> 
> Thanks Michal. There is still a lingering issue though, because we
> currently skip the prepare phase (we don't have a switchdev_trans
> structure that would make sense here), we are not checking that the
> underlying switch device driver does actually support
> port_vlan_add/port_vlan_del, and qca8k currently does not. I will submit
> a v2 patch that also takes care of that.

David, please discard this version, I will submit a version that
properly emulates the prepare/commit phase such that no assumptions are
broken, this will take care of both issues at once. Thanks!
-- 
Florian