netdev - Re: [PATCH net-next] net: marvell: neta: disable comphy when setting mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190301.112329.1478093691426120842.davem@davemloft.net>
Date:   Fri, 01 Mar 2019 11:23:29 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     marek.behun@....cz
Cc:     netdev@...r.kernel.org, rmk+kernel@...linux.org.uk
Subject: Re: [PATCH net-next] net: marvell: neta: disable comphy when
 setting mode

From: Marek Behún <marek.behun@....cz>
Date: Mon, 25 Feb 2019 17:43:03 +0100

> The comphy driver for Armada 3700 by Miquèl Raynal (which is currently
> in linux-next) does not actually set comphy mode when phy_set_mode_ext
> is called. The mode is set at next call of phy_power_on.
> 
> Update the driver to semantics similar to mvpp2: helper
> mvneta_comphy_init sets comphy mode and powers it on.
> When mode is to be changed in mvneta_mac_config, first power the comphy
> off, then call mvneta_comphy_init (which sets the mode to new one).
> 
> Only do this when new mode is different from old mode.
> 
> This should also work for Armada 38x, since in that comphy driver
> methods power_on and power_off are unimplemented.
> 
> Signed-off-by: Marek Behún <marek.behun@....cz>

Applied, thanks.