netdev - Re: [PATCH bpf-next 2/4] bpf/verifier: fix code formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fda23d5e-6de3-ab2f-107c-8abc1abaaef8@fb.com>
Date:   Fri, 1 Mar 2019 19:23:44 +0000
From:   Alexei Starovoitov <ast@...com>
To:     Andrii Nakryiko <andriin@...com>,
        "andrii.nakryiko@...il.com" <andrii.nakryiko@...il.com>,
        Yonghong Song <yhs@...com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "Song Liu" <songliubraving@...com>
Subject: Re: [PATCH bpf-next 2/4] bpf/verifier: fix code formatting

On 2/28/19 5:37 PM, Andrii Nakryiko wrote:
> -#define REALLOC_STATE_FN(NAME, COUNT, FIELD, SIZE)			\
> -static int realloc_##NAME##_state(struct bpf_func_state *state, int size, \
> -				  bool copy_old)			\
> -{									\
> -	u32 old_size = state->COUNT;					\
> -	struct bpf_##NAME##_state *new_##FIELD;				\
> -	int slot = size / SIZE;						\
> -									\
> -	if (size <= old_size || !size) {				\
> -		if (copy_old)						\
> -			return 0;					\
> -		state->COUNT = slot * SIZE;				\
> -		if (!size && old_size) {				\
> -			kfree(state->FIELD);				\
> -			state->FIELD = NULL;				\
> -		}							\
> -		return 0;						\
> -	}								\
> +#define REALLOC_STATE_FN(NAME, COUNT, FIELD, SIZE)			     \
> +static int realloc_##NAME##_state(struct bpf_func_state *state, int size,    \
> +				  bool copy_old)			     \
> +{									     \
> +	u32 old_size = state->COUNT;					     \

what is the change here?
extra tab at the end of every line?
I think that adds too much noise to git history.
I'd rather keep this bit as-is.