netdev - Re: [PATCH v3 net] net: phy: phylink: fix uninitialized variable in phylink_get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190301.113131.1752709783119341823.davem@davemloft.net>
Date:   Fri, 01 Mar 2019 11:31:31 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     linux@...linux.org.uk, andrew@...n.ch, f.fainelli@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH v3 net] net: phy: phylink: fix uninitialized variable
 in phylink_get_mac_state

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Tue, 26 Feb 2019 19:29:22 +0100

> When debugging an issue I found implausible values in state->pause.
> Reason in that state->pause isn't initialized and later only single
> bits are changed. Also the struct itself isn't initialized in
> phylink_resolve(). So better initialize state->pause and other
> not yet initialized fields.
> 
> v2:
> - use right function name in subject
> v3:
> - initialize additional fields
> 
> Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied and queued up for -stable.