lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <9bcd6a2389a8ffce41768ddc8b224daedacf76b7.camel@perches.com> Date: Fri, 01 Mar 2019 14:22:30 -0800 From: Joe Perches <joe@...ches.com> To: Matthias Maennich <maennich@...gle.com> Cc: Vlad Yasevich <vyasevich@...il.com>, Neil Horman <nhorman@...driver.com>, Marcelo Ricardo Leitner <marcelo.leitner@...il.com>, "David S. Miller" <davem@...emloft.net>, linux-sctp@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] sctp: chunk.c: correct format string for size_t in printk On Thu, 2019-02-28 at 11:36 +0000, Matthias Maennich wrote: > According to Documentation/core-api/printk-formats.rst, size_t should be > printed with %zu, rather than %Zu. > > In addition, using %Zu triggers a warning on clang (-Wformat-extra-args): [] > diff --git a/net/sctp/chunk.c b/net/sctp/chunk.c [] > @@ -192,7 +192,7 @@ struct sctp_datamsg *sctp_datamsg_from_user(struct sctp_association *asoc, > if (unlikely(!max_data)) { > max_data = sctp_min_frag_point(sctp_sk(asoc->base.sk), > sctp_datachk_len(&asoc->stream)); > - pr_warn_ratelimited("%s: asoc:%p frag_point is zero, forcing max_data to default minimum (%Zu)", > + pr_warn_ratelimited("%s: asoc:%p frag_point is zero, forcing max_data to default minimum (%zu)", > __func__, asoc, max_data); trivia: the format is also missing a terminating '\n'
Powered by blists - more mailing lists