netdev - Re: [PATCH net-next v4 1/6] net: devlink: turn devlink into a built-in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190301072304.GF2314@nanopsycho>
Date:   Fri, 1 Mar 2019 08:23:04 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     davem@...emloft.net, mkubecek@...e.cz, andrew@...n.ch,
        f.fainelli@...il.com, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net-next v4 1/6] net: devlink: turn devlink into a
 built-in

Thu, Feb 28, 2019 at 05:02:56PM CET, jakub.kicinski@...ronome.com wrote:
>On Thu, 28 Feb 2019 16:01:25 +0100, Jiri Pirko wrote:
>> Tue, Feb 26, 2019 at 04:34:02AM CET, jakub.kicinski@...ronome.com wrote:
>> >diff --git a/net/Kconfig b/net/Kconfig
>> >index 62da6148e9f8..1efe1f9ee492 100644
>> >--- a/net/Kconfig
>> >+++ b/net/Kconfig
>> >@@ -429,21 +429,12 @@ config NET_SOCK_MSG
>> > 	  with the help of BPF programs.
>> > 
>> > config NET_DEVLINK
>> >-	tristate "Network physical/parent device Netlink interface"
>> >+	bool "Network physical/parent device Netlink interface"  
>> 
>> Wouldn't "default y" be better?
>
>No opinion.  It used to be 'n', it didn't change here..  But we can
>change if we write convincing enough commit message :)
>
>Did you see cases where people "forget" to enable it?

I just did :) But I believe that is what's going to happen in the future.

>
>> > 	help
>> > 	  Network physical/parent device Netlink interface provides
>> > 	  infrastructure to support access to physical chip-wide config and
>> > 	  monitoring.
>> >   
>
>