netdev - Re: [PATCH net-next] net: dsa: mv88e6xxx: support in-band signalling with external PHY for 1000BaseX/2500BaseX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190302201307.GA10359@lunn.ch>
Date:   Sat, 2 Mar 2019 21:13:07 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: support in-band signalling
 with external PHY for 1000BaseX/2500BaseX

On Sat, Mar 02, 2019 at 04:57:32PM +0100, Heiner Kallweit wrote:
> Propagate the external PHY settings also in 1000BaseX and
> 2500BaseX mode.

Hi Heiner

I don't think this is needed. 1000BaseX and 2500BaseX does not support
inband signalling. So the mac_config() call for these modes should
include the needed speed configuration. I've used 1000BaseX with an
SFP and there was no need to configure anything.

    Andrew