netdev - Re: [PATCH v2 net] ipv4: Add ICMPv6 support when parse route ipproto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190301.164234.33116600327008363.davem@davemloft.net>
Date:   Fri, 01 Mar 2019 16:42:34 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     liuhangbin@...il.com
Cc:     netdev@...r.kernel.org, dsahern@...il.com,
        roopa@...ulusnetworks.com, sd@...asysnail.net
Subject: Re: [PATCH v2 net] ipv4: Add ICMPv6 support when parse route
 ipproto

From: Hangbin Liu <liuhangbin@...il.com>
Date: Wed, 27 Feb 2019 16:15:29 +0800

> For ip rules, we need to use 'ipproto ipv6-icmp' to match ICMPv6 headers.
> But for ip -6 route, currently we only support tcp, udp and icmp.
> 
> Add ICMPv6 support so we can match ipv6-icmp rules for route lookup.
> 
> v2: As David Ahern and Sabrina Dubroca suggested, Add an argument to
> rtm_getroute_parse_ip_proto() to handle ICMP/ICMPv6 with different family.
> 
> Reported-by: Jianlin Shi <jishi@...hat.com>
> Fixes: eacb9384a3fe ("ipv6: support sport, dport and ip_proto in RTM_GETROUTE")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Applied and queued up for -stable, thanks.