netdev - Re: [PATCH net-next RESEND] devlink: fix kdoc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190301.170055.1852205324263425973.davem@davemloft.net>
Date:   Fri, 01 Mar 2019 17:00:55 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com, jiri@...nulli.us
Subject: Re: [PATCH net-next RESEND] devlink: fix kdoc

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Wed, 27 Feb 2019 11:36:36 -0800

> devlink suffers from a few kdoc warnings:
> 
> net/core/devlink.c:5292: warning: Function parameter or member 'dev' not described in 'devlink_register'
> net/core/devlink.c:5351: warning: Function parameter or member 'port_index' not described in 'devlink_port_register'
> net/core/devlink.c:5753: warning: Function parameter or member 'parent_resource_id' not described in 'devlink_resource_register'
> net/core/devlink.c:5753: warning: Function parameter or member 'size_params' not described in 'devlink_resource_register'
> net/core/devlink.c:5753: warning: Excess function parameter 'top_hierarchy' description in 'devlink_resource_register'
> net/core/devlink.c:5753: warning: Excess function parameter 'reload_required' description in 'devlink_resource_register'
> net/core/devlink.c:5753: warning: Excess function parameter 'parent_reosurce_id' description in 'devlink_resource_register'
> net/core/devlink.c:6451: warning: Function parameter or member 'region' not described in 'devlink_region_snapshot_create'
> net/core/devlink.c:6451: warning: Excess function parameter 'devlink_region' description in 'devlink_region_snapshot_create'
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Acked-by: Jiri Pirko <jiri@...lanox.com>
> ---
> Looks like the discussion about the port flavours may take a while,
> posting this clean up separately :)

Applied, thanks Jakub.