netdev - Re: [PATCH net-next] net: sched: set dedicated tcf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXfPoc_5rg1Yj3ACMXNqqq7ERmjgJc8oFhjLL8s5nH4VQ@mail.gmail.com>
Date:   Fri, 1 Mar 2019 17:17:08 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH net-next] net: sched: set dedicated tcf_walker flag when
 tp is empty

On Thu, Feb 28, 2019 at 7:49 AM Vlad Buslov <vladbu@...lanox.com> wrote:
>
> However, if we revert NULL fixes dump will print general tp information
> for same tp twice (once correctly before dumping all filters on the tp, and
> second time when called for bogus NULL filter), like this:
>
> filter protocol ip pref 1 flower chain 0
> filter protocol ip pref 1 flower chain 0

What I don't understand is how could we dump twice here,
particularly the second dump. You insert a bogus NULL filter
in case for retry? I thought you do the same like for tc actions,
where you insert an error pointer which can't be dumped.