netdev - Re: [PATCH net-next 4/5] net: phy: don't export gen10g_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 3 Mar 2019 17:12:38 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 4/5] net: phy: don't export gen10g_read_status

On 03.03.2019 16:58, Andrew Lunn wrote:
> On Sat, Mar 02, 2019 at 05:15:56PM +0100, Heiner Kallweit wrote:
>> gen10g_read_status is deprecated, therefore stop exporting it.
>> We don't want to encourage anybody to use it.
> 
> Hi Florian, Heiner
> 
Hi Andrew,

> We should consider what we want to do with the generic 10G driver.
> 
> Can a c45 PHY be expected to work using a generic driver? We know
> 1000BaseT is not going to work, that needs vendor registers. But the
> rest might?
> 
I think so. When looking at the Aquantia driver it should work with
reduced functionality with a generic c45 driver.

> I think we either need to drop the generic 10G driver, or make it use
> all the new code which has been added over the last month.
> 
Not sure whether anybody is relying on the gen10g driver currently.
I'd say we could replace gen10g with a genc45 driver. It could provide
the basic functionality for a new C45 PHY model until there's a
dedicated PHY driver supporting the vendor-specific stuff and 1000BaseT.

>     Andrew
> 
Heiner