lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 3 Mar 2019 17:31:54 +0000 From: Eli Britstein <elibr@...lanox.com> To: Roi Dayan <roid@...lanox.com>, "Gustavo A. R. Silva" <gustavo@...eddedor.com>, Saeed Mahameed <saeedm@...lanox.com>, Leon Romanovsky <leon@...nel.org>, "David S. Miller" <davem@...emloft.net> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH][next] net/mlx5e: Remove redundant assignment Reviewed-by: Eli Britstein <elibr@...lanox.com> On 3/3/2019 5:20 PM, Roi Dayan wrote: > > On 02/03/2019 21:39, Gustavo A. R. Silva wrote: >> Remove redundant assignment to tun_entropy->enabled. >> >> Addesses-Coverity-ID: 1477328 ("Unused value") >> Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling port tunnel entropy calculation") > the commit doesn't fix any real issue but is more of a cleanup. > so I'm not sure if fixes line is relevant or not. > beside that looks ok. > > Reviewed-by: Roi Dayan <roid@...lanox.com> > > >> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com> >> --- >> drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c >> index 40f4a19b1ce1..be69c1d7941a 100644 >> --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c >> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c >> @@ -80,10 +80,8 @@ void mlx5_init_port_tun_entropy(struct mlx5_tun_entropy *tun_entropy, >> mlx5_query_port_tun_entropy(mdev, &entropy_flags); >> tun_entropy->num_enabling_entries = 0; >> tun_entropy->num_disabling_entries = 0; >> - tun_entropy->enabled = entropy_flags.calc_enabled; >> - tun_entropy->enabled = >> - (entropy_flags.calc_supported) ? >> - entropy_flags.calc_enabled : true; >> + tun_entropy->enabled = entropy_flags.calc_supported ? >> + entropy_flags.calc_enabled : true; >> } >> >> static int mlx5_set_entropy(struct mlx5_tun_entropy *tun_entropy, >>
Powered by blists - more mailing lists