netdev - Re: [PATCH 25/29] netfilter: nf_conntrack: ensure that CONNTRACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 3 Mar 2019 11:27:45 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Pablo Neira Ayuso <pablo@...filter.org>,
        netfilter-devel@...r.kernel.org
Cc:     davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH 25/29] netfilter: nf_conntrack: ensure that
 CONNTRACK_LOCKS is power of 2

Hello!

On 02.03.2019 21:37, Pablo Neira Ayuso wrote:

> From: Li RongQing <lirongqing@...du.com>
> 
> CONNTRACK_LOCKS is divisor when computer array index, if it is power of

    Computing?

> 2, compiler will optimize modulo operation as bitwise AND, or else
> modulo will lower performance.
> 
> Suggested-by: Florian Westphal <fw@...len.de>
> Signed-off-by: Li RongQing <lirongqing@...du.com>
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>
[...]

MBR, Sergei