netdev - Re: question about memory leak in ip_mc_del1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190304.101633.1998818339852915958.davem@davemloft.net>
Date:   Mon, 04 Mar 2019 10:16:33 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     maowenan@...wei.com
Cc:     edumazet@...gle.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kuznet@....inr.ac.ru
Subject: Re: question about memory leak in ip_mc_del1_src

From: maowenan <maowenan@...wei.com>
Date: Mon, 4 Mar 2019 20:47:42 +0800

> 			pmc->tomb = psf;
> 			rv = 1;         //if it does not kfree(psf), will it lead to memory leak after this line?

pmc->tomb points to psf, why should we free it?