lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 03 Mar 2019 20:46:16 -0800 (PST) From: David Miller <davem@...emloft.net> To: f.fainelli@...il.com Cc: netdev@...r.kernel.org, hkallweit1@...il.com, michal.vokac@...ft.com, andrew@...n.ch, vivien.didelot@...il.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next v2] net: dsa: Use prepare/commit phase in dsa_slave_vlan_rx_add_vid() From: Florian Fainelli <f.fainelli@...il.com> Date: Fri, 1 Mar 2019 10:37:25 -0800 > We were skipping the prepare phase which causes some problems with at > least a couple of drivers: > > - mv88e6xxx chooses to skip programming VID = 0 with -EOPNOTSUPP in > the prepare phase, but we would still try to force this VID since we > would only call the commit phase and so we would get the driver to > return -EINVAL instead > > - qca8k does not currently have a port_vlan_add() callback implemented, > yet we would try to call that unconditionally leading to a NPD > > Fix both issues by conforming to the current model doing a > prepare/commit phase, this makes us consistent throughout the code and > assumptions. > > Reported-by: Heiner Kallweit <hkallweit1@...il.com> > Reported-by: Michal Vokáč <michal.vokac@...ft.com> > Fixes: 061f6a505ac3 ("net: dsa: Add ndo_vlan_rx_{add, kill}_vid implementation") > Signed-off-by: Florian Fainelli <f.fainelli@...il.com> Applied, thanks Florian.
Powered by blists - more mailing lists