netdev - Re: [PATCH net-next] net/sched: act_tunnel_key: Fix double free dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 04 Mar 2019 10:53:34 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     wenxu@...oud.cn
Cc:     vladbu@...lanox.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net/sched: act_tunnel_key: Fix double free
 dst_cache

From: wenxu@...oud.cn
Date: Sat,  2 Mar 2019 22:50:21 +0800

> From: wenxu <wenxu@...oud.cn>
> 
> dst_cache_destroy will be called in dst_release
> 
> dst_release-->dst_destroy_rcu-->dst_destroy-->metadata_dst_free
> -->dst_cache_destroy
> 
> It should not call dst_cache_destroy before dst_release
> 
> Fixes: 41411e2fd6b8 ("net/sched: act_tunnel_key: Add dst_cache support")
> Signed-off-by: wenxu <wenxu@...oud.cn>

This does not apply cleanly to net-next, please respin.