netdev - Re: [PATCH] net: dsa: read mac address from DT for slave device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190304073122.GA2598@vkoul-mobl>
Date:   Mon, 4 Mar 2019 13:01:22 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     xiaofeis@...eaurora.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Niklas Cassel <niklas.cassel@...aro.org>,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: dsa: read mac address from DT for slave device

On 04-03-19, 11:46, xiaofeis@...eaurora.org wrote:
> On 2019-02-22 22:26, Andrew Lunn wrote:
> > On Fri, Feb 22, 2019 at 06:28:15PM +0530, Vinod Koul wrote:
> > > From: Xiaofei Shen <xiaofeis@...eaurora.org>
> > > 
> > > Before creating a slave netdevice, get the mac address from DTS and
> > > apply in case it is valid.
> > > 
> > > Signed-off-by: Xiaofei Shen <xiaofeis@...eaurora.org>
> > > Signed-off-by: Vinod Koul <vkoul@...nel.org>
> > 
> > Hi Xiaofei, Vinod
> > 
> > It would be good to document this in the binding.
> > 
> >    Andrew
> 
> From 4c8597161975dbef5fbe814aeee93599b4c57d37 Mon Sep 17 00:00:00 2001
> From: xiaofeis <xiaofeis@...eaurora.org>
> Date: Fri, 1 Mar 2019 13:54:52 +0800
> Subject: [PATCH] net: dsa: Add support for port mac address
> 
> Allow port network device's mac address to be retrieved from the
> device tree.
> 
> Signed-off-by: xiaofeis <xiaofeis@...eaurora.org>
> ---
>  Documentation/devicetree/bindings/net/dsa/dsa.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.txt
> b/Documentation/devicetree/bindings/net/dsa/dsa.txt
> index cfe8f64..1816f82 100644
> --- a/Documentation/devicetree/bindings/net/dsa/dsa.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/dsa.txt
> @@ -71,6 +71,10 @@ properties, described in binding documents:
>  			  Documentation/devicetree/bindings/net/fixed-link.txt
>  			  for details.
> 
> +- local-mac-address	: See
> +			  Documentation/devicetree/bindings/net/ethernet.txt
> +			  for details.
> +

Can you send this as independent patch to Dave and cc netdev and others
on this thread. This looks good to me so feel free to add

Reviewed-by: Vinod Koul <vkoul@...nel.org>

>  Example
> 
>  The following example shows three switches on three MDIO busses,
> @@ -99,6 +103,7 @@ linked into one DSA cluster.
>  			port@1 {
>  				reg = <1>;
>  				label = "lan1";
> +				local-mac-address = [000000000001];
>  			};
> 
>  			port@2 {

-- 
~Vinod