netdev - Re: [PATCH net] sctp: call iov_iter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190304120944.GA9244@hmswarspite.think-freely.org>
Date:   Mon, 4 Mar 2019 07:09:44 -0500
From:   Neil Horman <nhorman@...driver.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        davem@...emloft.net,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Subject: Re: [PATCH net] sctp: call iov_iter_revert() after sending ABORT

On Sun, Mar 03, 2019 at 04:50:26PM +0800, Xin Long wrote:
> The user msg is also copied to the abort packet when doing SCTP_ABORT in
> sctp_sendmsg_check_sflags(). When SCTP_SENDALL is set, iov_iter_revert()
> should have been called for sending abort on the next asoc with copying
> this msg. Otherwise, memcpy_from_msg() in sctp_make_abort_user() will
> fail and return error.
> 
> Fixes: 4910280503f3 ("sctp: add support for snd flag SCTP_SENDALL process in sendmsg")
> Reported-by: Ying Xu <yinxu@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>
> ---
>  net/sctp/socket.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/sctp/socket.c b/net/sctp/socket.c
> index 65d6d04..a2771b3 100644
> --- a/net/sctp/socket.c
> +++ b/net/sctp/socket.c
> @@ -1866,6 +1866,7 @@ static int sctp_sendmsg_check_sflags(struct sctp_association *asoc,
>  
>  		pr_debug("%s: aborting association:%p\n", __func__, asoc);
>  		sctp_primitive_ABORT(net, asoc, chunk);
> +		iov_iter_revert(&msg->msg_iter, msg_len);
>  
>  		return 0;
>  	}
> -- 
> 2.1.0
> 
> 
Acked-by: Neil Horman <nhorman@...driver.com>