netdev - Re: [PATCH net] net: hns3: add rmb() for rx description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2ca7e5e9-2d6a-4a76-8a33-eab28679a957@huawei.com>
Date:   Tue, 5 Mar 2019 09:04:07 +0800
From:   tanhuazhong <tanhuazhong@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <salil.mehta@...wei.com>, <yisen.zhuang@...wei.com>,
        <linuxarm@...wei.com>, <shenjian15@...wei.com>
Subject: Re: [PATCH net] net: hns3: add rmb() for rx description



On 2019/3/4 13:15, David Miller wrote:
> From: Huazhong Tan <tanhuazhong@...wei.com>
> Date: Sat, 2 Mar 2019 16:49:30 +0800
> 
>> From: Jian Shen <shenjian15@...wei.com>
>>
>> HW can not guarantee complete write desc->rx.size, even though
>> HNS3_RXD_VLD_B has been set. Driver needs to add rmb() instruction
>> to make sure desc->rx.size is always valid.
>>
>> Fixes: e55970950556 ("net: hns3: Add handling of GRO Pkts not fully RX'ed in NAPI poll")
>> Signed-off-by: Jian Shen <shenjian15@...wei.com>
>> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com>
> 
> dma_rmb() is more appropriate here and more efficient.
> 

Thanks, will send V2  to fix it.

> .
>