netdev - Re: [PATCH net v2] ipv4/route: fail early when inet dev is missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190306.103757.1493556167593143047.davem@davemloft.net>
Date:   Wed, 06 Mar 2019 10:37:57 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, dsa@...ulusnetworks.com
Subject: Re: [PATCH net v2] ipv4/route: fail early when inet dev is missing

From: Paolo Abeni <pabeni@...hat.com>
Date: Wed,  6 Mar 2019 10:42:53 +0100

> If a non local multicast packet reaches ip_route_input_rcu() while
> the ingress device IPv4 private data (in_dev) is NULL, we end up
> doing a NULL pointer dereference in IN_DEV_MFORWARD().
> 
> Since the later call to ip_route_input_mc() is going to fail if
> !in_dev, we can fail early in such scenario and avoid the dangerous
> code path.
> 
> v1 -> v2:
>  - clarified the commit message, no code changes
> 
> Reported-by: Tianhao Zhao <tizhao@...hat.com>
> Fixes: e58e41596811 ("net: Enable support for VRF with ipv4 multicast")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> Reviewed-by: David Ahern <dsahern@...il.com>

Applied and queued up for -stable.