netdev - Re: [PATCH net] fou, fou6: avoid uninit-value in gue_err() and gue6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Mar 2019 20:33:13 +0100
From:   Stefano Brivio <sbrivio@...hat.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        syzbot <syzkaller@...glegroups.com>,
        Sabrina Dubroca <sd@...asysnail.net>
Subject: Re: [PATCH net] fou, fou6: avoid uninit-value in gue_err() and
 gue6_err()

On Wed,  6 Mar 2019 10:41:00 -0800
Eric Dumazet <edumazet@...gle.com> wrote:

> My prior commit missed the fact that these functions
> were using udp_hdr() (aka skb_transport_header())
> to get access to GUE header.

Ouch, I totally missed this too. :/

> Since use pskb_transport_may_pull() does not exist yet,

Nit: s/use //

> we have to add transport_offset to our pskb_may_pull() calls.

Thanks for fixing this.

Acked-by: Stefano Brivio <sbrivio@...hat.com>

-- 
Stefano