netdev - Re: [PATCH net] net: hns3: Fix a logical vs bitwise typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Mar 2019 17:13:29 +0800
From:   Yunsheng Lin <linyunsheng@...wei.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Yisen Zhuang <yisen.zhuang@...wei.com>
CC:     Salil Mehta <salil.mehta@...wei.com>,
        "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH net] net: hns3: Fix a logical vs bitwise typo

On 2019/3/6 16:12, Dan Carpenter wrote:
> There were a couple logical ORs accidentally mixed in with the bitwise
> ORs.

Thanks for the fix.

Reviewed-by: Yunsheng Lin <linyunsheng@...wei.com>

> 
> Fixes: e8149933b1fa ("net: hns3: remove hnae3_get_bit in data path")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> Very recent bug.
> 
>  drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> index 3cb43b1f1c2e..1e4efc47c7a5 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> @@ -2321,8 +2321,8 @@ static void hns3_rx_checksum(struct hns3_enet_ring *ring, struct sk_buff *skb,
>  	if (!(bd_base_info & BIT(HNS3_RXD_L3L4P_B)))
>  		return;
>  
> -	if (unlikely(l234info & (BIT(HNS3_RXD_L3E_B) | BIT(HNS3_RXD_L4E_B) ||
> -				 BIT(HNS3_RXD_OL3E_B) ||
> +	if (unlikely(l234info & (BIT(HNS3_RXD_L3E_B) | BIT(HNS3_RXD_L4E_B) |
> +				 BIT(HNS3_RXD_OL3E_B) |
>  				 BIT(HNS3_RXD_OL4E_B)))) {
>  		u64_stats_update_begin(&ring->syncp);
>  		ring->stats.l3l4_csum_err++;
>