netdev - [PATCH iproute2] iprule: fix printing hint about unresolved iifname and oifname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20190306110400.25252-1-thaller@redhat.com>
Date:   Wed,  6 Mar 2019 12:04:00 +0100
From:   Thomas Haller <thaller@...hat.com>
To:     netdev@...r.kernel.org
Cc:     stephen@...workplumber.org, Thomas Haller <thaller@...hat.com>
Subject: [PATCH iproute2] iprule: fix printing hint about unresolved iifname and oifname

    # ip rule add priority 10 iif eth1 goto 10000 protocol 10

was displayed as

    10:     from all iif eth1 [detached] goto 10000unresolved proto mrt

now:

    10:     from all iif eth1 [detached] goto 10000 [unresolved] proto mrt

Fixes: 0dd4ccc56c0e ("iprule: add json support")

Signed-off-by: Thomas Haller <thaller@...hat.com>
---
 ip/iprule.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ip/iprule.c b/ip/iprule.c
index 4e9437de..0bd4c636 100644
--- a/ip/iprule.c
+++ b/ip/iprule.c
@@ -455,7 +455,7 @@ int print_rule(struct nlmsghdr *n, void *arg)
 			print_string(PRINT_ANY, "goto", "goto %s", "none");
 
 		if (frh->flags & FIB_RULE_UNRESOLVED)
-			print_null(PRINT_ANY, "unresolved", "unresolved", NULL);
+			print_null(PRINT_ANY, "unresolved", " [unresolved]", NULL);
 	} else if (frh->action == FR_ACT_NOP) {
 		print_null(PRINT_ANY, "nop", "nop", NULL);
 	} else if (frh->action != FR_ACT_TO_TBL) {
-- 
2.20.1