netdev - Re: [PATCH net] gre: fix kernel panic when using lw tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7a4e598-d433-0253-378d-2ffcafb259f0@6wind.com>
Date:   Wed, 6 Mar 2019 14:55:24 +0100
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     davem@...emloft.net
Cc:     netdev@...r.kernel.org, wenxu <wenxu@...oud.cn>,
        Alan Maguire <alan.maguire@...cle.com>
Subject: Re: [PATCH net] gre: fix kernel panic when using lw tunnel

Le 06/03/2019 à 11:32, Nicolas Dichtel a écrit :
> There was several problems:
>  - skb_dst(skb) can be NULL when the packet comes from a gretap tunnel;
>  - skb_dst(skb)->ops may point to md_dst_ops, which doesn't set ->mtu
>    handler, thus calling dst_mtu() leads to a panic.
> 
> I also wonder if ->cow_metrics may be called if skb_dst(skb)->ops points
> to ovs_dst_ops.
> 
> Don't try to do anything in one of those cases.
> 
> Fixes: 962924fa2b7a ("ip_gre: Refactor collect metatdata mode tunnel xmit to ip_md_tunnel_xmit")
> CC: wenxu <wenxu@...oud.cn>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Please, drop it, Alan's version is better.


Regards,
Nicolas