netdev - Re: [PATCH] peak_usb: fix clang build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190307.094013.220142928583766646.davem@davemloft.net>
Date:   Thu, 07 Mar 2019 09:40:13 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     wg@...ndegger.com, mkl@...gutronix.de, ndesaulniers@...gle.com,
        gustavo@...eddedor.com, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] peak_usb: fix clang build warning

From: Arnd Bergmann <arnd@...db.de>
Date: Thu,  7 Mar 2019 11:31:55 +0100

> Clang points out undefined behavior when building the pcan_usb_pro driver:
> 
> drivers/net/can/usb/peak_usb/pcan_usb_pro.c:136:15: error: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs]
> 
> Changing the function prototype to avoid argument promotion in the
> varargs call avoids the warning, and should make this well-defined.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.