netdev - Re: [PATCH] net: stmmac: Avoid sometimes uninitialized Clang warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOdk3iedWAbKOTR2UvQn-JLMZuU4_Jz6J=rDdjz0=_tNAGg@mail.gmail.com>
Date:   Thu, 7 Mar 2019 09:54:19 -0800
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, mcoquelin.stm32@...il.com,
        netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        clang-built-linux@...glegroups.com,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH] net: stmmac: Avoid sometimes uninitialized Clang warnings

On Thu, Mar 7, 2019 at 9:49 AM David Miller <davem@...emloft.net> wrote:
>
> From: Nathan Chancellor <natechancellor@...il.com>
> Date: Thu,  7 Mar 2019 09:21:01 -0700
>
> > @@ -565,7 +565,7 @@ static int stmmac_hwtstamp_set(struct net_device *dev, struct ifreq *ifr)
> >       u32 ts_master_en = 0;
> >       u32 ts_event_en = 0;
> >       u32 value = 0;
> > -     u32 sec_inc;
> > +     u32 sec_inc = 0;
> >       bool xmac;
>
> Please don't break the reverse christmas tree ordering here, thank you.

Every codebase has its own unique code style. *wonders how
clang-format could or could not handle that rule*

Thanks for sending the patch Nathan; if you could resend with the
declaration order changed so that the line width decreases going down
in the order, you can add my Reviewed-by tag.
-- 
Thanks,
~Nick Desaulniers