netdev - Re: [PATCH net] nfp: fix simple vNIC mailbox length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190307.110105.359292353280607549.davem@davemloft.net>
Date:   Thu, 07 Mar 2019 11:01:05 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        dirk.vandermerwe@...ronome.com
Subject: Re: [PATCH net] nfp: fix simple vNIC mailbox length

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Thu,  7 Mar 2019 10:52:13 -0800

> From: Dirk van der Merwe <dirk.vandermerwe@...ronome.com>
> 
> The simple vNIC mailbox length should be 12 decimal and not 0x12.
> Using a decimal also makes it clear this is a length value and not
> another field within the simple mailbox defines.
> 
> Found by code inspection, there are no known firmware configurations
> where this would cause issues.

Therefore I am not queueing this up for -stable, let me know if I
still should.

> Fixes: 527d7d1b9949 ("nfp: read mailbox address from TLV caps")
> Signed-off-by: Dirk van der Merwe <dirk.vandermerwe@...ronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Applied, thanks.