netdev - Re: [PATCH net] xsk: fix potential crash in xsk_diag_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2411b303-0ef5-ec67-cab9-e43e543d6b10@iogearbox.net>
Date:   Thu, 7 Mar 2019 11:22:55 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Eric Dumazet <edumazet@...gle.com>,
        Alexei Starovoitov <ast@...nel.org>
Cc:     netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        bpf <bpf@...r.kernel.org>, syzbot <syzkaller@...glegroups.com>,
        Björn Töpel <bjorn.topel@...el.com>,
        Magnus Karlsson <magnus.karlsson@...el.com>
Subject: Re: [PATCH net] xsk: fix potential crash in xsk_diag_put_umem()

On 03/05/2019 06:31 PM, Eric Dumazet wrote:
> Fixes two typos in xsk_diag_put_umem()
> 
> syzbot reported the following crash :
> 
> kasan: CONFIG_KASAN_INLINE enabled
> kasan: GPF could be caused by NULL-ptr deref or user memory access
> general protection fault: 0000 [#1] PREEMPT SMP KASAN
> CPU: 1 PID: 7641 Comm: syz-executor946 Not tainted 5.0.0-rc7+ #95
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> RIP: 0010:xsk_diag_put_umem net/xdp/xsk_diag.c:71 [inline]
> RIP: 0010:xsk_diag_fill net/xdp/xsk_diag.c:113 [inline]
> RIP: 0010:xsk_diag_dump+0xdcb/0x13a0 net/xdp/xsk_diag.c:143
[...]
> 
> Fixes: a36b38aa2af6 ("xsk: add sock_diag interface for AF_XDP")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>
> Cc: Björn Töpel <bjorn.topel@...el.com>
> Cc: Daniel Borkmann <daniel@...earbox.net>
> Cc: Magnus Karlsson <magnus.karlsson@...el.com>

Applied, thanks!