netdev - Re: [PATCH bpf 1/2] selftests: bpf: fix compilation with out-of-tree $(OUTPUT)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <21fb1443-4e0a-fcdc-f649-eada06e09420@iogearbox.net>
Date:   Thu, 7 Mar 2019 11:29:42 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Stanislav Fomichev <sdf@...gle.com>, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Cc:     davem@...emloft.net, ast@...nel.org
Subject: Re: [PATCH bpf 1/2] selftests: bpf: fix compilation with out-of-tree
 $(OUTPUT)

On 03/06/2019 08:59 PM, Stanislav Fomichev wrote:
> A bunch of related changes lumped together:
> * Create prog_tests and verifier output directories; these don't exist with
>   out-of-tree $(OUTPUT)
> * Add missing -I (via separate TEST_{PROGS,VERIFIER}_CFLAGS) for the main tree
>   ($(PWD) != $(OUTPUT) for out-of-tree)
> * Add libbpf.a dependency for test_progs_32 (parallel make fails otherwise)
> * Add missing "; \" after "cd" when generating test.h headers
> 
> Tested by:
> $ alias m="make -s -j$(nproc)"
> $ m -C tools/testing/selftests/bpf/ clean
> $ m -C tools/lib/bpf/ clean
> $ rm -rf xxx; mkdir xxx; m -C tools/testing/selftests/bpf/ OUTPUT=$PWD/xxx
> $ m -C tools/testing/selftests/bpf/
> 
> Fixes: 3f30658830f3 ("selftests: bpf: break up test_progs - preparations")
> Fixes: 2dfb40121ee8 ("selftests: bpf: prepare for break up of verifier tests")
> Fixes: 3ef84346c561 ("selftests: bpf: makefile support sub-register code-gen test mode")
> 

Btw, please no newline between these tags, I've fixed it up.

> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>

Applied, thanks!