netdev - Re: [PATCH net] route: set the deleted fnhe fnhe_daddr to 0 in ip_del

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190308.105122.656526755979170615.davem@davemloft.net>
Date:   Fri, 08 Mar 2019 10:51:22 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, dsahern@...il.com, jmaxwell37@...il.com,
        jmaxwell@...hat.com
Subject: Re: [PATCH net] route: set the deleted fnhe fnhe_daddr to 0 in
 ip_del_fnhe to fix a race

From: Xin Long <lucien.xin@...il.com>
Date: Fri,  8 Mar 2019 14:50:54 +0800

> The race occurs in __mkroute_output() when 2 threads lookup a dst:
> 
>   CPU A                 CPU B
>   find_exception()
>                         find_exception() [fnhe expires]
>                         ip_del_fnhe() [fnhe is deleted]
>   rt_bind_exception()
> 
> In rt_bind_exception() it will bind a deleted fnhe with the new dst, and
> this dst will get no chance to be freed. It causes a dev defcnt leak and
> consecutive dmesg warnings:
> 
>   unregister_netdevice: waiting for ethX to become free. Usage count = 1
> 
> Especially thinks Jon to identify the issue.

I did "s/thinks/thanks/" here.

> This patch fixes it by setting fnhe_daddr to 0 in ip_del_fnhe() to stop
> binding the deleted fnhe with a new dst when checking fnhe's fnhe_daddr
> and daddr in rt_bind_exception().
> 
> It works as both ip_del_fnhe() and rt_bind_exception() are protected by
> fnhe_lock and the fhne is freed by kfree_rcu().
> 
> Fixes: deed49df7390 ("route: check and remove route cache when we get route")
> Signed-off-by: Jon Maxwell <jmaxwell37@...il.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied and queues up for -stable, thank you.