netdev - Re: [PATCH net] sctp: remove sched init from sctp_stream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190308.112503.775390652844673739.davem@davemloft.net>
Date:   Fri, 08 Mar 2019 11:25:03 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
        marcelo.leitner@...il.com, nhorman@...driver.com
Subject: Re: [PATCH net] sctp: remove sched init from sctp_stream_init

From: Xin Long <lucien.xin@...il.com>
Date: Fri,  8 Mar 2019 15:49:16 +0800

> syzbot reported a NULL-ptr deref caused by that sched->init() in
> sctp_stream_init() set stream->rr_next = NULL.
> 
>   kasan: GPF could be caused by NULL-ptr deref or user memory access
>   RIP: 0010:sctp_sched_rr_dequeue+0xd3/0x170 net/sctp/stream_sched_rr.c:141
>   Call Trace:
>     sctp_outq_dequeue_data net/sctp/outqueue.c:90 [inline]
>     sctp_outq_flush_data net/sctp/outqueue.c:1079 [inline]
>     sctp_outq_flush+0xba2/0x2790 net/sctp/outqueue.c:1205
> 
> All sched info is saved in sout->ext now, in sctp_stream_init()
> sctp_stream_alloc_out() will not change it, there's no need to
> call sched->init() again, since sctp_outq_init() has already
> done it.
> 
> Fixes: 5bbbbe32a431 ("sctp: introduce stream scheduler foundations")
> Reported-by: syzbot+4c9934f20522c0efd657@...kaller.appspotmail.com
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied and queued up for -stable, thanks.