netdev - Re: [net-next PATCH] net/rds: Return proper "tos" value to user-space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52a2653e-6ac6-bdc7-5e6e-a7763eef968d@oracle.com>
Date:   Fri, 8 Mar 2019 14:37:19 -0800
From:   Gerd Rausch <gerd.rausch@...cle.com>
To:     "santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>,
        Yanjun Zhu <yanjun.zhu@...cle.com>, netdev@...r.kernel.org
Cc:     David Miller <davem@...emloft.net>
Subject: Re: [net-next PATCH] net/rds: Return proper "tos" value to user-space

On 07/03/2019 17.37, santosh.shilimkar@...cle.com wrote:
>> --- a/net/rds/connection.c
>> +++ b/net/rds/connection.c
>> @@ -736,6 +736,7 @@ static int rds_conn_info_visitor(struct rds_conn_path *cp, void *buffer)
>>       cinfo->next_rx_seq = cp->cp_next_rx_seq;
>>       cinfo->laddr = conn->c_laddr.s6_addr32[3];
>>       cinfo->faddr = conn->c_faddr.s6_addr32[3];
>> +    cinfo->tos = conn->c_tos;
>>       strncpy(cinfo->transport, conn->c_trans->t_name,
>>           sizeof(cinfo->transport));
>>       cinfo->flags = 0;
>>
> Transport function populates it "iinfo->tos" so 'rds-info -I'
> already should be showing the correct output but we should popullate
> it here to for socket option so looks good
> 

"rds-info -I" did show the correct output, but

"rds-info -n" did not:

% rds-info -n
RDS Connections:
      LocalAddr      RemoteAddr  Tos           NextTX           NextRX Flgs
  192.168.253.2   192.168.253.1  159            46940            46264 --C-

> Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>
> 

Thanks,

  Gerd