netdev - Re: [PATCH V2 net] net: hns3: add dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 08 Mar 2019 14:44:10 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     tanhuazhong@...wei.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        salil.mehta@...wei.com, yisen.zhuang@...wei.com,
        linuxarm@...wei.com, shenjian15@...wei.com
Subject: Re: [PATCH V2 net] net: hns3: add dma_rmb() for rx description

From: Huazhong Tan <tanhuazhong@...wei.com>
Date: Wed, 6 Mar 2019 11:26:37 +0800

> From: Jian Shen <shenjian15@...wei.com>
> 
> HW can not guarantee complete write desc->rx.size, even though
> HNS3_RXD_VLD_B has been set. Driver needs to add dma_rmb()
> instruction to make sure desc->rx.size is always valid.
> 
> Fixes: e55970950556 ("net: hns3: Add handling of GRO Pkts not fully RX'ed in NAPI poll")
> Signed-off-by: Jian Shen <shenjian15@...wei.com>
> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com>
> ---
> V1->V2: fixes comment from David Miller

Applied and queued up for -stable, thank you.