netdev - Re: [PATCH net] tcp: handle inet_csk_reqsk_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190309090234.GA29222@pc-2.home>
Date:   Sat, 9 Mar 2019 10:02:35 +0100
From:   Guillaume Nault <gnault@...hat.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] tcp: handle inet_csk_reqsk_queue_add() failures

On Fri, Mar 08, 2019 at 03:47:25PM -0800, Eric Dumazet wrote:
> 
> On 03/08/2019 02:40 PM, Guillaume Nault wrote:
> > On Fri, Mar 08, 2019 at 02:34:07PM -0800, Eric Dumazet wrote:
> > 
> > Long term, do we want to keep the WARN_ON_ONCE()? If so, we should
> > probably remove the comment.
> 
> We want to keep the warning.
> 
> We do not have a way to tell if the req was ever inserted in a hash table, so better play safe.
> 
Then I'm going to remove the /* temporary debugging */ line, so that
nobody will be tempted to drop the test.

Thanks for your feedbacks.

Guillaume