netdev - Re: [PATCH RESEND net] net: phy: xgmiitorgmii: Support generic PHY status read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 9 Mar 2019 17:19:12 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Harini Katakam <harinik@...inx.com>
Cc:     Michal Simek <michal.simek@...inx.com>,
        Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH RESEND net] net: phy: xgmiitorgmii: Support generic PHY
 status read

> Related to this, I have a query on how the DT node for gmii2rgmii should look.
> One of the users of gmii2rgmii is Cadence macb driver. In Xilinx tree, we use
> this piece of code to register this mdiobus:
> + mdio_np = of_get_child_by_name(np, "mdio");
> + if (mdio_np) {
> + of_node_put(mdio_np);
> + err = of_mdiobus_register(bp->mii_bus, mdio_np);
> + if (err)
> + goto err_out_unregister_bus;
> 
> And the DT node looks like this:
> ethernet {
>     phy-mode = "gmii";
>     phy-handle = <&extphy>;
> 
>     mdio {
>         extphy {
>             reg = <x>;
>         };
>         gmii_to_rgmii{
>             compatible = "xlnx,gmii-to-rgmii-1.0";
>             phy-handle = <&extphy>;
>             reg = <x>;
>         };
>     };
> };

Hi Harini

You have this setup:
  
MAC <==> GMII2RGMII <==> RGMII_PHY

So you want the MAC phy-handle to point to the gmii_to_rgmii 'PHY'.

Feel free to submit a patch extending
Documentation/devicetree/bindings/net/xilinx_gmii2rgmii.txt to include
a MAC node, etc.

   Andrew