netdev - Re: [PATCH net] net: keep refcount warning in reqsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 09 Mar 2019 19:52:04 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     gnault@...hat.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net] net: keep refcount warning in reqsk_free()

From: Guillaume Nault <gnault@...hat.com>
Date: Sat, 9 Mar 2019 10:26:53 +0100

> As Eric Dumazet said, "We do not have a way to tell if the req was ever
> inserted in a hash table, so better play safe.".
> Let's remove this comment, so that nobody will be tempted to drop the
> WARN_ON_ONCE() line.
> 
> Signed-off-by: Guillaume Nault <gnault@...hat.com>

Applied, thanks.