netdev - Re: [PATCH] isdn: hfcpci: fix potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 10 Mar 2019 10:56:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kjlu@....edu
Cc:     pakki001@....edu, isdn@...ux-pingi.de, baijiaju1990@...il.com,
        gustavo@...eddedor.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] isdn: hfcpci: fix potential NULL pointer dereference

From: Kangjie Lu <kjlu@....edu>
Date: Fri,  8 Mar 2019 23:46:04 -0600

> In case ioremap fails, the fix reports an error and returns.
> 
> Signed-off-by: Kangjie Lu <kjlu@....edu>

First, you shouldn't print the information log message if this fails.

Second you are leaking hc->hw.fifos, you have to clean up any resources
allocated up until this point if you fail.