netdev - Re: [PATCH] net: lan9303: fix missing error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 10 Mar 2019 11:00:48 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kjlu@....edu
Cc:     pakki001@....edu, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: lan9303: fix missing error handling

From: Kangjie Lu <kjlu@....edu>
Date: Sun, 10 Mar 2019 03:08:56 -0500

> Both lan9303_phy_write and regmap_write may fail. The fix adds
> the error handling to print error messages upon failure.
> 
> Signed-off-by: Kangjie Lu <kjlu@....edu>

It's ignored elsewhere in this driver in places you haven't handled.

I doubt this is much of an improvement to the driver to be quite
honest.

I disagree with the mantra that just because an error is potentially
returned, that it always must be checked.