netdev - Re: [PATCH net] net/x25: fix use-after-free in x25_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190310.110456.655715804613903690.davem@davemloft.net>
Date:   Sun, 10 Mar 2019 11:04:56 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        syzbot+04babcefcd396fabec37@...kaller.appspotmail.com,
        andrew.hendry@...il.com
Subject: Re: [PATCH net] net/x25: fix use-after-free in x25_device_event()

From: Eric Dumazet <edumazet@...gle.com>
Date: Sun, 10 Mar 2019 09:07:14 -0700

> In case of failure x25_connect() does a x25_neigh_put(x25->neighbour)
> but forgets to clear x25->neighbour pointer, thus triggering use-after-free.
> 
> Since the socket is visible in x25_list, we need to hold x25_list_lock
> to protect the operation.
> 
> syzbot report :
 ...
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot+04babcefcd396fabec37@...kaller.appspotmail.com

Applied and queued up for -stable.