netdev - Re: [PATCH v2 net] lan743x: Fix RX Kernel Panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Mar 2019 11:36:43 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     Bryan.Whitehead@...rochip.com
Cc:     netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v2 net] lan743x: Fix RX Kernel Panic

From: Bryan Whitehead <Bryan.Whitehead@...rochip.com>
Date: Mon, 11 Mar 2019 13:39:39 -0400

> @@ -2290,7 +2306,9 @@ static int lan743x_rx_ring_init(struct lan743x_rx *rx)
>  
>  	rx->last_head = 0;
>  	for (index = 0; index < rx->ring_size; index++) {
> -		ret = lan743x_rx_allocate_ring_element(rx, index);
> +		struct sk_buff *new_skb = lan743x_rx_allocate_skb(rx);
> +
> +		ret = lan743x_rx_init_ring_element(rx, index, new_skb);

Need to check new_skb for NULL.

Again....