netdev - Re: [PATCH net] net/x25: reset state in x25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190311.154111.1100327955282723755.davem@davemloft.net>
Date:   Mon, 11 Mar 2019 15:41:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        andrew.hendry@...il.com, syzkaller@...glegroups.com
Subject: Re: [PATCH net] net/x25: reset state in x25_connect()

From: Eric Dumazet <edumazet@...gle.com>
Date: Mon, 11 Mar 2019 13:48:44 -0700

> In case x25_connect() fails and frees the socket neighbour,
> we also need to undo the change done to x25->state.
> 
> Before my last bug fix, we had use-after-free so this
> patch fixes a latent bug.
> 
> syzbot report :
 ...
> Fixes: 95d6ebd53c79 ("net/x25: fix use-after-free in x25_device_event()")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: andrew hendry <andrew.hendry@...il.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied and queued up, thanks.